Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old interface code for inject_tlm #1689

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

jmthomas
Copy link
Contributor

@jmthomas jmthomas commented Jun 14, 2022

closes #1511

Turns out a previous refactor already removed the logging for inject_tlm. Not sure what additional 'cmd' logging the ticket is referring to.

@jmthomas jmthomas requested a review from a user June 14, 2022 18:54
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1689 (df70911) into master (f785bd0) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
+ Coverage   78.19%   78.44%   +0.24%     
==========================================
  Files         235      208      -27     
  Lines       18150    16948    -1202     
==========================================
- Hits        14193    13295     -898     
+ Misses       3957     3653     -304     
Impacted Files Coverage Δ
app/controllers/metadata_controller.rb
app/controllers/application_controller.rb
config/environments/test.rb
config/application.rb
app/controllers/timeline_controller.rb
app/channels/streaming_channel.rb
app/controllers/completed_script_controller.rb
app/channels/application_cable/channel.rb
app/controllers/trigger_group_controller.rb
app/controllers/environment_controller.rb
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f785bd0...df70911. Read the comment docs.

@jmthomas jmthomas merged commit 498f384 into master Jun 14, 2022
@jmthomas jmthomas deleted the cleanup_inject_tlm branch June 14, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inject_tlm / cmd new parameter to suppress log messages
1 participant